[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5810 [Stem]: Implement verification of server descriptor

#5810: Implement verification of server descriptor
-------------------------+--------------------------------------------------
 Reporter:  reganeet     |          Owner:  reganeet
     Type:  enhancement  |         Status:  new     
 Priority:  normal       |      Milestone:          
Component:  Stem         |        Version:          
 Keywords:               |         Parent:          
   Points:               |   Actualpoints:          
-------------------------+--------------------------------------------------

Comment(by atagar):

 Pushed an adaptation of your change - thanks for the patch!
 https://gitweb.torproject.org/stem.git/commitdiff/40a971105ff162d0caa9e0a1c5fa3c0f7d3c2b72

 Changes included...
 - Making the rsa module import optional. Not only is it not a builtin, but
 it also isn't packaged for most platforms. Hence when we make a deb and
 rpm we won't be able to have a stated dependency on it, which in turn
 means that this won't function for most users. However, as the commit
 message mentions I looked around for alternatives and found them lacking
 so guess we'll need to go with this and hope that the python-rsa folks
 someday get their act together and package their library.

 - The fingerprint attribute is optional (in the wild descriptors may not
 have it), so accounted for this in the change.

 > That's weird, since I think I've removed all the CRs, and in my
 emacs/vim there is no CR remaining in server_descriptors.py.

 If you run "git show d793809" then you should see the issue, where the
 whole file appears to be deleted and then re-added with the altered
 newlines. I ended up needing to run 'git diff --ignore-space-at-eol HEAD^'
 and then re-apply your change by hand to the current master. Not the end
 of the world, but it took a bit of work.

 Again, thanks for the patch! Leaving this ticket open for the remaining
 validation implementation.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5810#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs