[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5519 [Vidalia]: Some improvements for torcontrol code (ControlConnection, ControlSocket classes)

#5519: Some improvements for torcontrol code (ControlConnection, ControlSocket
classes)
---------------------+------------------------------------------------------
 Reporter:  sebb     |          Owner:  sebb                
     Type:  task     |         Status:  needs_review        
 Priority:  minor    |      Milestone:                      
Component:  Vidalia  |        Version:  Vidalia: 0.3.1-alpha
 Keywords:           |         Parent:                      
   Points:           |   Actualpoints:                      
---------------------+------------------------------------------------------

Comment(by chiiph):

 Replying to [comment:9 sebb]:
 > first commit for infinite loop fix:
 >
 https://github.com/sebthestampede/vidalia/commit/6205ea37dc834390f4a21be8ad75939e7827064a
 > (same branch name)
 > what about second "changes" file name, for the ControlSocket cleanup ?
 the ticket number is the same

 You can either use a .2 suffix for the file name, or just put the two
 changelog entries in the same file. Whatever you like best.
 The important part in here is to make both changes explicit for the person
 that might look at the commit log or the changelog.

 >
 > I never saw that bug with PROTOCOLINFO, but your fix looks ok to me.
 > Another thing is, shouldn't we remove deleted RecvWaiter object from the
 _recvQueue ? Now it looks like a dangling pointer stays in there (after
 "delete w;" line). And call "delete" on object returned by
 _recvQueue.dequeue();

 Hm, actually no. The "delete w" should be for both branches of the if. In
 the first case, the waiter is dequeued when the answer is found in
 onReadyRead, otherwise the getResult call wouldn't return.
 I'd like to get this code clearer too, but I'm not entirely sure if there
 is a better way to go here.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5519#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs