[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5604 [Tor Client]: If DisableNetwork is set, we open all our ports and then close them at each setconf

#5604: If DisableNetwork is set, we open all our ports and then close them at each
setconf
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by ln5):

 FWIW, 074bf72 looks correct to me given that there are no "listener
 connections" which are not of the type CONN_TYPE_CONTROL_LISTENER.

 Since retry_listener_ports() doesn't really _close_ any ports, the new
 formal parameter 'close_all_noncontrol' seems slightly misnamed.  We
 could make it 'uint8_t ports_filter' but that would make the function
 harder to understand from its prototype alone.

 At least it needs documentation.  Maybe adding something like this?

   If <b>close_all_noncontrol</b> is 1, don't consider any ports in
   <b>ports</b> which are not control listener ports.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5604#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs