[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4873 [Tor Relay]: [Error] connection_or_handle_event_cb(): Bug: connection_or.c:1281: connection_or_handle_event_cb: Assertion handshakes >= 2 failed; aborting.

#4873: [Error] connection_or_handle_event_cb(): Bug: connection_or.c:1281:
connection_or_handle_event_cb: Assertion handshakes >= 2 failed; aborting.
----------------------------------+-----------------------------------------
 Reporter:  stars                 |          Owner:                     
     Type:  defect                |         Status:  needs_review       
 Priority:  major                 |      Milestone:  Tor: 0.2.3.x-final 
Component:  Tor Relay             |        Version:  Tor: 0.2.3.10-alpha
 Keywords:  tls crash regression  |         Parent:                     
   Points:                        |   Actualpoints:                     
----------------------------------+-----------------------------------------

Comment(by ln5):

 Perhaps getting rid of the return in the first if clause in the block
 where tor_tls_used_v1_handshake(conn->tls) != 0 (handshakes == 1)
 would be proper?  (We do return after the if clause so the return here
 and shouldn't bring the idea of returning from each block into this
 block too.)

 And a log string fix: s/unexpectedly unexpectedly/unexpectedly/1.
 Unless that's meant to be a funny way of expressing major
 non-expectedness of course.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4873#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs