[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11271 [Obfsproxy]: ScrambleSuit and obfsproxy repositories should be merged

#11271: ScrambleSuit and obfsproxy repositories should be merged
-----------------------------+-------------------------------
     Reporter:  phw          |      Owner:  phw
         Type:  enhancement  |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Obfsproxy    |    Version:
   Resolution:               |   Keywords:  scramblesuit, git
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------

Comment (by asn):

 Replying to [comment:9 yawning]:
 > I told asn that I will also do a review of the branch since I'm somewhat
 familiar with most of the changes and the codebase.
 > Test case stuff:
 >  * "Add scramblesuit unittests for the state module."
 `8ac1dfab7f0a58de632fbea94ff9d543405b062c`
 >  * "Add TicketTest unittest." `634a0fa1b44eacf2115fe90f84b911c8497053ed`
 >  * "Use TransportConfig in scramblesuit unittests."
 `ccc70ba4ceedef7d99a6a0dc1c34661d56c654eb`
 >
 > Why was `def test4_ioerrorFail( self ):` dropped from the state tests?
 >

 I'm also wondering about that. Maybe Philipp knows (unittest changes are
 from `3b97bd28ff073a048aee016b145447630e20da6c` in scramblesuit repo).

 > Random thoughts:
 >  * Are we going to maintain the `doc/scramblesuit/ChangeLog` file?
 Should we add a note there saying that it's for historical purposes only
 or remove it?
 >

 Adding a note stating its historical value makes sense to me.

 Thanks for the review!
 >

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11271#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs