[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11820 [Obfsproxy]: circuit `NoneType` in obfs3 handshake callbacks

#11820: circuit `NoneType` in obfs3 handshake callbacks
---------------------------+-----------------
     Reporter:  asn        |      Owner:  asn
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+-----------------

Comment (by asn):

 I'm not sure if it makes sense checking whether `self.circuit` exists, if
 we remove the code that sets it to `None`.

 As a fix to this bug, I'm thinking of using the fix to #11769 (that adds
 `self.closed` guards) and also removing the part of the code that sets
 `self.transport.circuit` to `None`.

 If this thing bites us again, we can do more elaborate fixes like the
 `@property` idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11820#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs