[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9701 [Firefox Patch Issues]: Prevent TorBrowser from creating clipboardcache turds
#9701: Prevent TorBrowser from creating clipboardcache turds
-------------------------------------+-------------------------------------
Reporter: cypherpunks | Owner: mikeperry
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Firefox Patch | Version:
Issues | Keywords: tbb-disk-leak,
Resolution: | interview, GeorgKoppen201405
Actual Points: | Parent ID:
Points: |
-------------------------------------+-------------------------------------
Comment (by mcs):
Here is the commit log (CVS revision 1.23) that shows when the concept of
writing to disk first landed in the Mozilla code:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/widget/src/xpwidgets/nsTransferable.cpp&rev=1.23
Unfortunately, this is ancient history and there is no reference to a bug
number. And the check in comment does not say why they changed things to
write clipboard data to disk rather than keep it in memory. My best guess
is that they just wanted to ensure that memory usage stayed as low as
possible.
I think your proposed fix is OK. It might be better to add a preference
or a compile-time method to disable the WriteCache() code (Mozilla would
be more like to accept a patch that uses such an approach). For example,
the kLargeDatasetSize value could be retrieved from a preference and a
zero value could mean "never write to disk."
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9701#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs