[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12114 [Tor]: Don't open DirPortFrontPage when DirPort not set/enabled (was: Don't open DirPortFrontPage when not a relay or DirPort not set)

#12114: Don't open DirPortFrontPage when DirPort not set/enabled
---------------------------+--------------------------------
     Reporter:  alphawolf  |      Owner:
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor        |    Version:  Tor: 0.2.5.4-alpha
   Resolution:             |   Keywords:  tor
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+--------------------------------

Comment (by alphawolf):

 Replying to [comment:1 arma]:
 > Why should we not open the file if we're not a relay but we set DirPort?
 Seems to me that if somebody sets DirPort and also sets DirPortFrontPage,
 then they want their DirPort to serve that string.

 Ahh, I mistakenly thought that tor required ORPort before it turned on any
 "server" functions (I first noticed this bug while `ClientOnly 1` was
 accidentally set).  I've revised the summary to be more accurate.

 I tested your patch, and it works in both cases where DirPort is not set,
 or DirPort is set in addition to `ClientOnly 1`.  Looks good!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12114#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs