Re: [tor-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#14429: Automated rounding of content window dimensions
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  torbutton, TorBrowserTeam201505R,
   Resolution:           |  GeorgKoppen201505R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Part 1

 The needs_revision is for the following parts

 {{{
   if (w !== window.outerWidth || h !== window.outerWidth) {
 }}}
 I guess you want `h !== window.outerHeight`.

 Looking at `largestMultipleLessThan()` I was wondering why you can't just
 use `Math.floor(max / factor) * factor`? Apart from that: where did you
 find that `Math.floor()` can take two parameters?
 The function name might be misleading as the result can be equal to `max`
 as well.

 In `computeTargetZoom()` could you explain why you need `Math.min() there?
 Why not just `w - xStep` and `h- yStep` given that they are always smaller
 than `w` and `y` and thus the former function as a boundary. (The second
 `Math.min()` seems to be missing `h` as the first parameter, no?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:110>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs