[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18402 [Core Tor/Tor]: Reduce duplicate code in parse_*_time functions

#18402: Reduce duplicate code in parse_*_time functions
-------------------------------+------------------------------------
 Reporter:  icanhasaccount     |          Owner:
     Type:  enhancement        |         Status:  needs_revision
 Priority:  Low                |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor       |        Version:  Tor: unspecified
 Severity:  Minor              |     Resolution:
 Keywords:  TorCoreTeam201604  |  Actual Points:
Parent ID:                     |         Points:  small
 Reviewer:  yawning            |        Sponsor:
-------------------------------+------------------------------------
Changes (by yawning):

 * status:  needs_review => needs_revision


Comment:

 Looks ok at a cursor glance, though invalid input to the new and improved
 functions will also now log at `LD_BUG` in addition to `LD_GENERAL` on
 invalid input (redundant and misleading) which is probably not what we
 want.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18402#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs