[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18988 [Core Tor/Tor]: log error level messages if relay (self) is not in consensus
#18988: log error level messages if relay (self) is not in consensus
--------------------------+---------------------
Reporter: cypherpunks | Owner:
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+---------------------
Comment (by cypherpunks):
Replying to [comment:2 cypherpunks]:
> What do you think about having a more serious log entry for such "hard
failures"? (relay dropped out of consensus)
I think it would be technically easy. For example using 'warning' instead:
{{{
--- a/src/or/status.c
+++ b/src/or/status.c
@@ -100,7 +100,7 @@ log_heartbeat(time_t now)
return -1; /* Something stinks, we won't even attempt this. */
else
if (!node_get_by_id(me->cache_info.identity_digest))
- log_fn(LOG_NOTICE, LD_HEARTBEAT, "Heartbeat: It seems like we are
not "
+ log_fn(LOG_WARN, LD_HEARTBEAT, "Heartbeat: It seems like we are
not "
"in the cached consensus.");
}
}}}
However I disagree about it being a 'hard failure', IMO is not even a
failure, the system is working fine.
> And wouldn't it make sense to check if we are in the consensus every
hour regardless of HeartbeatPeriod? (is that check that expensive?)
Dunno.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18988#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs