[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16943 [Core Tor/Tor]: Implement prop250 (Random Number Generation During Tor Voting)

#16943: Implement prop250 (Random Number Generation During Tor Voting)
---------------------------------------+-----------------------------------
 Reporter:  asn                        |          Owner:  dgoulet
     Type:  enhancement                |         Status:  needs_revision
 Priority:  High                       |      Milestone:  Tor:
Component:  Core Tor/Tor               |  0.2.9.x-final
 Severity:  Normal                     |        Version:
 Keywords:  tor-hs, TorCoreTeam201605  |     Resolution:
Parent ID:  #8244                      |  Actual Points:
 Reviewer:  nickm                      |         Points:  large
                                       |        Sponsor:  SponsorR-must
---------------------------------------+-----------------------------------

Comment (by teor):

 You probably want `tor_parse_ulong()` here, because on i386, min is 1, and
 max is effectively `(long)UINT32_MAX`, which is -1.
 {{{
 long tor_parse_long(const char *s, int base, long min,
                     long max, int *ok, char **next);
 ...
 uint32_t version;
 ...
 version = (uint32_t) tor_parse_long(value, 10, 1, UINT32_MAX, NULL, NULL);
 }}}

 I think we could warn in the tor_parse_* functions when this happens, see
 #19063.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16943#comment:61>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs