[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket



#18886: consider removing Pocket
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:
     Type:  defect                          |  arthuredelstein
 Priority:  Medium                          |         Status:
Component:  Applications/Tor Browser        |  needs_revision
 Severity:  Normal                          |      Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605  |        Version:
Parent ID:                                  |     Resolution:
 Reviewer:                                  |  Actual Points:
                                            |         Points:
                                            |        Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  ff45-esr, TorBrowserTeam201605R => ff45-esr,
     TorBrowserTeam201605


Comment:

 Neat idea and I guess Mozilla would even be amenable to take that patch.
 However, that still does not seem enough. I stumbled over another Pocket
 button while looking at the Reader functionality (see:
 https://mxr.mozilla.org/mozilla-
 esr45/source/browser/modules/ReaderParent.jsm#81). There are even more
 instances of `CustomizableUI.getPlacementOfWidget("pocket-button")` we
 might want to take care of when upstreaming (even though I did not figure
 out how to get a related Pocket button shown in Tor Browser for these
 cases).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18886#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs