[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18619 [Applications/Tor Browser]: TBB/ESR45 reports "InvalidStateError" in browser console

#18619: TBB/ESR45 reports "InvalidStateError" in browser console
---------------------------------------------+-----------------------------
 Reporter:  arthuredelstein                  |          Owner:  tbb-team
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_review
Component:  Applications/Tor Browser         |      Milestone:
 Severity:  Normal                           |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |     Resolution:
Parent ID:                                   |  Actual Points:
 Reviewer:                                   |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by arthuredelstein):

 Replying to [comment:5 mcs]:
 > Replying to [comment:4 arthuredelstein]:
 > > Here's a patch that attempts to fix the problem.
 > >
 > > https://github.com/arthuredelstein/tor-browser/commit/18619+1
 > > Hash 96e76624a5e354bb059782dbe1fdeb5f8345af4e
 >
 > With this patch, an InvalidState error is no longer logged during
 browser startup. We still see one when we open the developer tools
 (Inspect Element). I don't know how difficult it would be to patch the
 underlying devtools/shared/async-storage.js code to avoid using IndexedDB
 when it has been disabled.

 Thanks for the review. That's a good suggestion. I wrote an in-memory
 implementation that is supposed to match the indexeedDB-based version:

 https://github.com/arthuredelstein/tor-browser/commit/18619+2
 Hash b875e25aade0323c85915e0c09eadaf44151524f

 This seems to correctly the browser console input history during a browser
 session. It also appears to eliminate the InvalidStateErrors both as a
 result of browser startup, entering things in the browser console, or
 using Inspect Element.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18619#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs