[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19139 [Core Tor/Tor]: Let Autoconf handle enabling C and POSIX extensions

#19139: Let Autoconf handle enabling C and POSIX extensions
--------------------------+-----------------------------------
 Reporter:  cypherpunks   |          Owner:
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Minor         |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+-----------------------------------
Changes (by cypherpunks):

 * status:  new => needs_information


Comment:

 FWIW the removal of the existing macros in the patch was done by grepping
 for `#define _` and removing  instances manually according to the list in
 the [https://www.gnu.org/software/autoconf/manual/autoconf.html#Posix-
 Variants Autoconf manual].

 And now for the `environ` variable. Research into the
 [http://pubs.opengroup.org/onlinepubs/9699919799/functions/exec.html POSIX
 standard] and the manpages of [https://manpages.debian.org/cgi-
 bin/man.cgi?query=environ Debian], [http://man.openbsd.org/?query=environ
 OpenBSD] and
 [https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man7/environ.7.html
 Mac OS X] shows that the external `environ` variable is declared in
 `unistd.h`. To be on the safe side the declaration in compat.c can be kept
 but it does not need to be conditionally because external variables can be
 declared multiple times (as long as their declaration is the same).
 Therefore the `environ` configure check can be removed. As this change is
 unrelated to the ticket description, I'll open a new ticket and refer back
 to this comment.

 One remaining question: does the initial patch need a changes file? If so,
 I'm happy to write one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19139#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs