[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22106 [Core Tor/Tor]: Initial Rust support
#22106: Initial Rust support
--------------------------+------------------------------------
Reporter: Sebastian | Owner:
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by Sebastian):
Replying to [comment:21 nickm]:
> Small questions. We shouldn't take any of these as blocking.
> * Have you tested this with out-of-tree builds?
> * Have you tried "make distcheck DISTCHECK_CONFIGURE_FLAGS='--enable-
rust'" to make sure that make distcheck still works when building rust?
Yes, that still works.
> * Do the various "make clean" targets work right?
All targets tested as a part of distcheck work, are there others?
> * What invokes clippy for us?
Nothing yet, it's not a part of this branch
> * where do we check rustc/cargo version?
there's a check during configure. We only test the rust version because
cargo versions "belong" to certain rust versions.
> * How will cross-compilation work?
Not at all yet.
> Small suggestions:
> * The "please report bugs" message .. should say "how" and "where" to
report, and remind people not to report ancient bugs. Otherwise we'll get
swamped with junk.
Ok.
> * test_rust.sh -- should it use ls to find the list of crates, rather
than having them hardwired?
we could do that i guess, will add it.
> * Let's label the autoconf option as "experimental" in the help
message.
Ok
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22106#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs