Re: [tor-bugs] #22301 [Core Tor/Stem]: make test-stem doesn't work

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#22301: make test-stem doesn't work
---------------------------+------------------------------------
 Reporter:  catalyst       |          Owner:  atagar
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Stem  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------

Comment (by catalyst):

 Thanks for looking into these and working on patches.

 I tried your latest changes and unfortunately still see all the failures
 that I reported above.  The tests indeed almost all work when I run from
 the top of the stem source tree, but that wasn't the problem that toby_
 initially reported.

 * `make test-stem` (and thus `make test-full`) still fails from the top of
 the tor source tree, failing to find `./src/or/tor`.  This should not be
 an unusual situation because `CodingStandards.md` recommends that people
 run `make test-full` to test their changes.  (If we don't expect `make
 test-full` to work, we should update `CodingStandards.md`.)
 * Applying the workaround of specifying an absolute path to the `tor`
 binary in the source tree when running `make test-stem` still produces the
 same errors in `test.integ.install` and `test.integ.process`.  I infer
 that `test.integ.install` expects its working directory to be the top of
 the stem source tree and not anywhere else, but this can't work with the
 current `make test-stem` rules in the tor source tree.
 * Running `./run_tests.py` from the top of the stem source tree (and
 giving it an absolute path to the `tor` binary in the tor source tree)
 clears the install problem but not the process problem.  Not having a
 system tor installed might be unusual but I think we should support that
 use case.  (Also we shouldn't be testing the system tor unless we
 specifically intend to.  Do we actually intend to test the system tor
 here?)

 I'm sorry if I misspoke about the `$PATH` issue.  I meant that I don't
 have a `tor` binary installed on this system, and somehow the tests were
 trying to look for a `tor` binary in my `$PATH`, not that I had an empty
 or missing `$PATH` environment variable.

 I saw that Jenkins runs automated tests in the stem source tree, but I
 didn't see anything that runs `make test-stem` or `make test-full` from
 the tor source tree, which is something that we should make sure works if
 we're recommending that developers run that when testing proposed changes
 to tor.

 I think I will make separate child tickets because these issues are
 partially separable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22301#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs