[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22415 [Applications/Tor Browser]: Format error in our pipeline patch
#22415: Format error in our pipeline patch
--------------------------------------+------------------------------
Reporter: arthuredelstein | Owner: tbb-team
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201705R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+------------------------------
Description changed by arthuredelstein:
Old description:
> I was building tor-browser.git with --enabled-debug and -Werror=format
> and it revealed a format error in our #5282 patch. The line is
> {{{
> fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined
> pipelined requests for host %s\n",
> alreadyPending+totalSent, totalAvailable, reqsSent,
> ci->Origin());
> }}}
> But the first three arguments after the format string are unsigned long
> integers, not long long integers.
New description:
I was building tor-browser.git with --enable-debug and -Werror=format and
it revealed a format error in our #5282 patch. The line is
{{{
fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined
pipelined requests for host %s\n",
alreadyPending+totalSent, totalAvailable, reqsSent,
ci->Origin());
}}}
But the first three arguments after the format string are unsigned long
integers, not long long integers.
--
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22415#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs