[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25960 [Core Tor/Tor]: Allow additional header lines in bandwidth measurements documents

#25960: Allow additional header lines in bandwidth measurements documents
-------------------------------------------------+-------------------------
 Reporter:  juga                                 |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  bwauth, 029-backport, 031-backport,  |  Actual Points:
  032-backport, 033-backport                     |
Parent ID:  #25925                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Thanks for the review.

 > Mock read_file_to_string to return the test data

 it does not use read_file_to_str, so i can't mock that one, it uses
 tor_fopen_cloexec and fgets.

 > Refactor the existing tor code so it reads the file to a string in one
 function A

 And A could actually use read_file_to_str

 Now i should also subtitute fgets, and instead change the loop read 512
 bytes from the previous str.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25960#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs