[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds
#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, boklm201805, | Actual Points:
TorBrowserTeam201805R |
Parent ID: #12968 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
I've not reviewed the patch rebasing yet. But here come some notes:
1) We are reverting 13e570f80cbfb299a8858ce6830e91a6cb40ab7b and suddenly
need `texinfo` for that? At least the comment suggest that without
reverting this patch we would not need it. Is that what you intended to
say with the comment?
2) Have you checked whether just passing the `no-insert-timestamp` flag to
`APPEND_CCFLAGS` is enough? Or just to `APPEND_LINKFLAGS`? It seems to me
either `no-insert-timstamp` is passed on to the linker in which case we
would not need that extra patch or it is not passed on, in which case I am
wondering why we add it to `APPEND_CCFLAGS`.
3) s/Therefor/Therefore/
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16472#comment:88>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs