Re: [tor-bugs] #26230 [Metrics/ExoneraTor]: Release ExoneraTor 2.1.0

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26230: Release ExoneraTor 2.1.0
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  task                |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  iwakeh,irl          |        Sponsor:
--------------------------------+------------------------------

Comment (by iwakeh):

 The release tarball is ok, all checks and tests pass, bytecode
 reproducible.

 When inspecting the release branch I noticed two (minor) issues:

 The following change replaces catching of the RuntimeException by catching
 IOException.  I think, we introduced the catch-RE in order to always have
 null returned in case of an unforseen error and _not_ excalate any
 exception.  Maybe add the catch-RE again, because we don't know what
 issues could cause jackson to throw a RE?

 {{{
 @@ -107,7 +99,7 @@ public class QueryResponse {
          return null;
        }
        return response;
 -    } catch (RuntimeException e) {
 +    } catch (IOException e) {
        logger.error("JSON decoding failed.", e);
      }
      return null;
 }}}

 And, the change log could state that the superfluous brackets caused
 broken links? But that's really nitpicking.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26230#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs