[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33789 [Core Tor/Tor]: Before making changes, move router pick address functions to their own C file
#33789: Before making changes, move router pick address functions to their own C
file
---------------------------+------------------------------------
Reporter: teor | Owner: dgoulet
Type: task | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, prop312 | Actual Points:
Parent ID: #33049 | Points: 1
Reviewer: nickm | Sponsor: Sponsor55-must
---------------------------+------------------------------------
Changes (by nickm):
* status: needs_review => needs_revision
Comment:
I can confirm that this is just code movement. However it seems that
travis is failing with `--disable-module-relay`.
As for the file names: I think relay_resolve_addr should maybe have a name
like relay_find_addr.c or something. It is about finding our own address,
not necessarily _resolving_ it. Resolving is what we do when we call
gethostbyname() or getaddrinfo(). Similarly, resolve_addr.c maybe ought to
be "resolve_own_addr", since it's not about finding just any address, but
about finding our own address? Not totally sure.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33789#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs