[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #34078 [Core Tor/Tor]: Fix compilation warnings with clang 10.0.0

#34078: Fix compilation warnings with clang 10.0.0
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 The preliminary patches looks good. In the `master` example PR, the
 comment `/* Fallthrough is to disallow since this means the bucket has
 reached 0. */` is erased in `hs_dos.c`. I think that is the only issue I
 could spot.

 I don't have Clang 10 locally to try it though.

 If the comment is restored, I think this can be merged.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34078#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs