Re: [tor-bugs] #34245 [Core Tor/Tor]: Declare variables in for loops in rend_service_dump_stats()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#34245: Declare variables in for loops in rend_service_dump_stats()
--------------------------+-----------------------------
 Reporter:  neel          |          Owner:  neel
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+-----------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:   => ahf


Comment:

 I think this change is fine.

 Neel, there is a significant amount of overhead for us to do these
 whitespace fixes with one ticket per N patches (for a pretty small N),
 where one of us have to review it, someone else needs to come in and do
 the merge.

 I think we should stop doing these as individual changes. If you want to
 solve the whitespace problems in Tor, please have a look at the work that
 happened in the beginning of this year where folks in the network team
 evaluated using clang-format to handle code-style in Tor automatically.

 We have a pretty costly code-review process for tor.git since (a) we are
 written in C and every line is a potential catastrophe waiting to happen,
 and (b) because we are a project where security is key.

 For me to review these small changes, I need to pull your branch on my
 local machine (in case Github's web interface isn't showing me the truth),
 then make a decision on the changes, comment on the ticket, then finally
 saying yay or nay. Then somebody else from the team goes in, have to go it
 over as well, and do the merge Doing this is just too much work for these
 small changes.

 If you want to help with the clang-format work that has been going on,
 please have a look at #29226.

 Thank you :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34245#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs