Re: [tor-bugs] #1883 [Tor Relay]: Include GeoIP database identifier in extra-info descriptors

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1883: Include GeoIP database identifier in extra-info descriptors
-------------------------+--------------------------------------------------
 Reporter:  karsten      |       Owner:                    
     Type:  enhancement  |      Status:  needs_review      
 Priority:  normal       |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |     Version:                    
 Keywords:               |      Parent:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 looks okay.  A couple of issues:

 In geoip_db_digest(), the documentation for the function should explain
 that calling hex_str() invalidates its return value.

 In extrainfo_dump_to_string:

 +        s[pos] = '\0';
 This should be unneeded, since tor_snprintf always nul-terminates.
 +        write_stats_to_extrainfo = 0;
 Why?  The right response on tor_snprintf() failing here is probably just
 to call the whole extrainfo a failure.

 Other than that looks fine.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1883#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs