[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2183 [Tor Relay]: router_rebuild_descriptor(): Bug: Couldn't generate extra-info descriptor
#2183: router_rebuild_descriptor(): Bug: Couldn't generate extra-info descriptor
-----------------------+----------------------------------------------------
Reporter: Falo | Owner: karsten
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor Relay | Version: Tor: 0.2.2.17-alpha
Keywords: | Parent:
-----------------------+----------------------------------------------------
Comment(by rransom):
Replying to [comment:13 karsten]:
> See updated branch fix2183 in my public repository. This patch takes the
(hopefully more robust) approach of joining smartlist elements to generate
the extra-info descriptor.
Your patch uses `log_err` to report conditions that will not crash Tor.
From src/common/torlog.h:
{{{
/** Error-level severity: for messages that only appear when something has
gone
* very wrong, and the Tor process can no longer proceed. */
#define LOG_ERR 3
}}}
We are considering handling messages with level LOG_ERR specially in
response to the current fix for #1125 -- in particular, the process of
logging error messages may itself destabilize or crash the Tor process, in
an attempt to report a useful error message to Windows Tor users who can
only read log messages through Vidalia.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2183#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs