[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2183 [Tor Relay]: router_rebuild_descriptor(): Bug: Couldn't generate extra-info descriptor

#2183: router_rebuild_descriptor(): Bug: Couldn't generate extra-info descriptor
-----------------------+----------------------------------------------------
 Reporter:  Falo       |       Owner:  karsten            
     Type:  defect     |      Status:  needs_review       
 Priority:  normal     |   Milestone:                     
Component:  Tor Relay  |     Version:  Tor: 0.2.2.17-alpha
 Keywords:             |      Parent:                     
-----------------------+----------------------------------------------------

Comment(by nickm):

 reviewing "fix2183":

   * Probably, we should esc_for_log any descriptors before logging
 them.... but logging them is probably not the best idea anyway, since our
 log buffer truncates after 10024 bytes.
   * No need to change this, but in the future, stuff like taking out that
 "opt " should really get its own commit.
   * I prefer having bridge_stats declared in the only block where it's
 used; there's no real reason to have it at the head of the function.
   * The definition of SIG_LEN really belongs near the declaration of
 router_append_dirobj_signature(), and wants to be called something more
 like DIROBJ_MAX_SIG_LEN .
   * Rather than dropping all stats when we exceed 50k, would it be at all
 useful to remove elements from the end of the chunks smartlist, one by
 one, until we are under 50k again?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2183#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs