[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5053 [Tor]: Fix IPv6 implementation for bridge statistics

#5053: Fix IPv6 implementation for bridge statistics
-----------------------------+----------------------------------------------
 Reporter:  karsten          |          Owner:  ln5               
     Type:  enhancement      |         Status:  needs_review      
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor              |        Version:                    
 Keywords:  ipv6 tor-bridge  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by andrea):

 Replying to [comment:36 andrea]:
 > I've reviewed this and then read nickm's review and found he had about
 the same set of observations I came up with.  The clear_geoip_db() thing
 and the alignment issue particularly stood out to me.  I'm satisfied that
 the clear_geoip_db() isn't failing to clear the database when reloading,
 but some of the code in geoip_load_file() seems a bit klunky to me still.
 That function starts off with a call to clear_geoip_db(), then does an
 init_geoip_countries() if it isn't NULL (isn't it always NULL after
 clear_geoip_db()?), then frees geoip_entries and replaces it with a new,
 empty smartlist_t.  Seems rather redundant.

 Apparently I have the stupid today.  I was looking at the old one when I
 wrote that.  The new geoip_load_file() seems much less silly.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5053#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs