[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7272 [Flashproxy]: flashproxy-client socket.error exception on Windows
#7272: flashproxy-client socket.error exception on Windows
------------------------+---------------------------------------------------
Reporter: aallai | Owner: dcf
Type: defect | Status: needs_revision
Priority: major | Milestone:
Component: Flashproxy | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Changes (by dcf):
* priority: minor => major
* status: needs_review => needs_revision
Comment:
Replying to [comment:1 aallai]:
> I have a fix for this at https://github.com/aallai/flashproxy.git,
branch ticket#7272.
>
> What I did was remove the setblocking call in listen_socket, so all the
sockets block.
> The client uses select so it should never block on reads. It can block
on sends, but the
> *Socket classes use sendall, so it seems like the intention was to block
there.
Okay, it looks reasonable.
I'd like you to edit the commit log. Saying that you removed a call to
setblocking(0) is not enough. You also need to describe the error that the
change fixes (exception on `sendall` on Windows) and why the program still
works with blocking sockets.
You can just clobber the current head of your 7272 branch with one having
a more descriptive log. (`git commit --amend`, `git push --force`.)
>
> Alternatively the *Socket classes could buffer the data and try
resending at another time,
> this would probably involve some extra threads though. Let me know if
this approach
> is better.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7272#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs