[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7267 [Tor]: src/or/channel.c:1315 channel_closed: Assertion chan->state == CHANNEL_STATE_CLOSING || chan->state == CHANNEL_STATE_CLOSED || chan->state == CHANNEL_STATE_ERROR failed;
#7267: src/or/channel.c:1315 channel_closed: Assertion chan->state ==
CHANNEL_STATE_CLOSING || chan->state == CHANNEL_STATE_CLOSED || chan->state
== CHANNEL_STATE_ERROR failed;
-----------------------+----------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version: Tor: 0.2.4.4-alpha
Keywords: tor-relay | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Changes (by andrea):
* status: new => needs_review
Comment:
Replying to [comment:17 nickm]:
> Just closed #7303 as a likely duplicate of this.
>
> Andrea, I think for the solution, or at least part of it, we need to
make it so that it's safe to call connection_mark_for_close on an OR
connection without necessarily also invoking
connection_or_close{_for_error,_normally}. So far there seem to be at
least three cases where we're marking generic connections without going
through the right "ahem, channels" -- there will probably be more.
See my check_for_orconn_on_close branch, which does this check and in
those cases calls connection_or_close_for_error() instead and logs a
warning.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7267#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs