[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6293 [Flashproxy]: Disable self when running in Tor browser

#6293: Disable self when running in Tor browser
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:  dcf           
     Type:  defect      |         Status:  needs_revision
 Priority:  normal      |      Milestone:                
Component:  Flashproxy  |        Version:                
 Keywords:              |         Parent:                
   Points:              |   Actualpoints:                
------------------------+---------------------------------------------------
Changes (by dcf):

  * status:  new => needs_revision


Comment:

 Thanks, this is good work.

 I'm willing to trade some false positives (and perhaps remove some false
 negatives) for an even simpler test. Grepping for "Permission denied" in
 error text strikes me as not robust. Similarly "Shockwave Flash": I don't
 want to couple this test too closely to the internals of Tor Browser.
 Checking `navigator.platform` seems redundant with the user-agent check.

 I'll bet that the user-agent comparison already gets us almost all the way
 there. To that let's add the `sessionStorage === null` and
 `navigator.mimeTypes.length == 0` tests, and make that the whole of the
 detection.

 Please do the above in the form of a patch against `flashproxy.js`, and
 attach the patch to the ticket. The function should be called
 `is_likely_tor_browser` or something similar. You can add a call to this
 function to `flashproxy_should_disable`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6293#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs