[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7328 [Stem]: Event Handling

#7328: Event Handling
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:  atagar        
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Stem         |        Version:                
 Keywords:  controller   |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by robinson):

  * status:  needs_review => needs_revision


Comment:

 atagar,

 So, I went through the events branch commit-by-commit and overall it looks
 very good.  Three quick comments and I'll try to open sub-tickets for two
 other items.

 I like that CIRC Event returns a fingerprint and nickname tuple in path.
 This was a minor bug in your personal TorCtl tree event handler that I
 just recently (this week) fixed for myself.

 Is it possible that stem.StreamClosureReason values map to an interger
 starting with 1 (i.e.
 stem.StreamClosureReason.index_of(stem.StreamClosureReason.MISC) = 1).  If
 so, I have written a Controller.close_stream method which could re-use
 stem.StreamClosureReason values for RELAY_END reason.

 The commit titled "Revised behavior for document signature methods" is not
 relevant to events.  It's not a big deal, but to avoid side effects
 merging this branch, maybe you could cherry-pick around it?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7328#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs