[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10088 [Tor]: Shutdown tor helpers properly with CREATE_BREAKAWAY_FROM_JOB (?)

#10088: Shutdown tor helpers properly with CREATE_BREAKAWAY_FROM_JOB (?)
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-pt
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by infinity0):

 [http://blogs.msdn.com/b/cjacks/archive/2009/07/10/how-to-work-around-
 program-compatibility-assistant-pca-jobobjects-interfering-with-your-
 jobobjects.aspx This] is probably a more direct explanation. We only need
 this fix for Windows Vista (and possibly above); we don't need it for
 Windows XP, where processes are not default-assigned to the UAC JobObject.

 An optional addition to this issue, would be for Tor itself to use the
 kill-children-on-death thing, example
 [http://stackoverflow.com/questions/53208/how-do-i-automatically-destroy-
 child-processes-in-windows/53214#53214 C++], our own Python example
 [https://github.com/infinity0/pyptlib/blob/33f090961c1e5d0587938a169c9d8107133ff646/pyptlib/util/subproc.py#L64
 part1]
 [https://github.com/infinity0/pyptlib/blob/33f090961c1e5d0587938a169c9d8107133ff646/pyptlib/util/subproc.py#L121
 part2]. (I had to tweak it from the C++ slightly, hopefully it's clear.)

 We have [ticket:10047] open for a clean long-term cross-platform solution
 to have managed child PTs die when Tor crashes. This shifts the
 responsibility from Tor to the child PT (using JobObjects, the
 responsibility remains with the parent), but has the advantage that the
 child PT has a chance to do cleanup tasks.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10088#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs