[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9069 [Flashproxy]: Set have_websocket_binary_frames for Firefox

#9069: Set have_websocket_binary_frames for Firefox
----------------------------+-------------------------------
     Reporter:  dcf         |      Owner:  dcf
         Type:  defect      |     Status:  needs_information
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:  easy
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+-------------------------------
Changes (by dcf):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:3 arlolra]:
 > Please see the attached.

 Can you explain this diff?
 {{{
 -    if (ua === null)
 +    if (ua == null)
 }}}
 If `ua` can be other than `null` but some other falsy value (what value?),
 I think I prefer to write it as
 {{{
 -    if (ua === null)
 +    if (!ua)
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9069#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs