[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10106 [EFF-HTTPS Everywhere]: Merge in jpds/master repo



#10106: Merge in jpds/master repo
--------------------------------------+--------------------------
     Reporter:  cypherpunks           |      Owner:  pde
         Type:  enhancement           |     Status:  needs_review
     Priority:  normal                |  Milestone:
    Component:  EFF-HTTPS Everywhere  |    Version:
   Resolution:                        |   Keywords:
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+--------------------------

Comment (by schoen):

 I made some changes to trivial-validate to make this pre-commit hook
 better handle a few cases.

 I think the pre-commit hook works great now, although it produces
 different output in the commit message editor if you git commit a modified
 file without first git adding it.  (The process still works, and the
 output is arguably correct; you get told that there are changes [that
 you're committing!] that haven't been staged for commit.  You wouldn't be
 told this without the pre-commit hook.)

 We also have a commit hook written by Yan which I think is meant to run
 server-side.  We could probably benefit from using both of them, and from
 adding even more tests to trivial-validate. :-)

 I'll try to pull in jpds's hook and apply a couple of my changes to it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10106#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs