[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10126 [Tor bundles/installation]: TBB-3.0-beta-1 include a non-stripped firefox binary

#10126: TBB-3.0-beta-1 include a non-stripped firefox binary
-------------------------------------+-------------------------------------
     Reporter:  isis                 |      Owner:  mikeperry
         Type:  defect               |     Status:  needs_review
     Priority:  blocker              |  Milestone:
    Component:  Tor                  |    Version:
  bundles/installation               |   Keywords:  tbb-3.0-stable-
   Resolution:                       |  blocker,gitian
Actual Points:                       |  Parent ID:
       Points:  9000                 |
-------------------------------------+-------------------------------------
Changes (by isis):

 * status:  new => needs_review


Old description:

> There have been two firefox binaries in TBB for a while, `firefox` and
> `firefox-bin`. Today, while messing around with Selenium for BridgeDB/TBB
> tests and trying to drive TBB from a sandboxed pypy, I noticed that one
> of these binaries is now non-stripped. My 3.0.2-alpha's `firefox-bin` is
> still there, but stripped, so I assume this was introduced in 3.0.3-alpha
> to build with the detached debugging symbols. We shouldn't ship a non-
> stripped binary, even if it's not being used.
>
> I think, to fix this, some changes might need to be made to the gitian-
> builder to get it to toss out the non-stripped binary, or just not
> package it.

New description:

 There have been two firefox binaries in TBB for a while, `firefox` and
 `firefox-bin`. Today, while messing around with Selenium for BridgeDB/TBB
 tests and trying to drive TBB from a sandboxed pypy, I noticed that one of
 these binaries is now non-stripped. My 3.0.2-alpha's `firefox-bin` is
 still there, but stripped, so I assume this was introduced in 3.0.3-alpha
 to build with the detached debugging symbols. We shouldn't ship a non-
 stripped binary, even if it's not being used.

 I think, to fix this, some changes might need to be made to the gitian-
 builder to get it to toss out the non-stripped binary, or just not package
 it.

 mikeperry already started building a test of it, but found that I missed
 doing a `mkdir -p Browser/components`. And mikeperry added the additional
 binary files that gk pointed out:

 {{{
 08:33 #tor-dev: GeKo) isis: re your fix for 10126: what about "webapprt-
 stub" or "mozilla-xremote-client" or "updater"...?
 09:17 #tor-dev: GeKo) isis: no problem :) one additional nit "firefix bin"
 -> "firefox bin"
 }}}

 And... mikeperry told me not to fix the typo (in my comment in
 gitian/descriptors/linux/gitian-firefox.yml L94) because he was already
 testing and it would conflict.

--

Comment:

 I already told mikeperry on IRC, but my
 [https://code.patternsinthevoid.net/?p=tor-browser-
 bundle.git;a=shortlog;h=refs/heads/fix/10126-strip-binaries patches to fix
 this issue are in this branch]. Unfortunately, my git server will only
 allow you to clone if I've already got your SSH key. You can still view
 the patches in gitweb otherwise. Sorry. :/

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10126#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs