[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9974 [Flashproxy]: packaging and installation scripts for facilitator

#9974: packaging and installation scripts for facilitator
-----------------------------+----------------------------
     Reporter:  infinity0    |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------

Comment (by dcf):

 Replying to [comment:11 infinity0]:
 > Replying to [comment:10 dcf]:
 > >
 [https://github.com/infinity0/flashproxy/commit/aafd15b8927e0d7519152d3e88f655b571037f04
 #diff-2751e08e60a242b8ab992d77d774e405L13 Setting FP_FACILITATOR in fp-
 reg.go.] It's good to make this externally configurable. I think it's
 better, however, to make the the configurable part a whole URL, and not
 just the domain part. We should support facilitators running on different
 ports and with different base paths. Run `go fmt` after making changes to
 Go files.
 > >
 >
 > I believe the existing code already supports this, since we only put
 https:// and /reg/ around FP_FACILITATOR which is just a string. (/reg/ is
 hard-coded into facilitator.cgi so I thought to leave it hard-coded here
 too.) I'll fix the docstring to mention this though, right now it just
 says "host[:port]".

 I'm actually thinking about the case where someone does
 {{{
         ScriptAliasMatch ^mybasepath/(.*) /usr/local/bin/facilitator.cgi$1
 }}}
 instead of
 {{{
         ScriptAliasMatch ^(.*) /usr/local/bin/facilitator.cgi$1
 }}}
 Then the reg path would be at /mybasepath/reg, rather than /reg. I think
 it's fine to leave the "reg" part hardcoded. I've thought about changing
 to something like this so we can serve an actual HTML page at /, with
 information about what the facilitator is. But I can easily take care of
 making the configuration a URL. [http://golang.org/pkg/net/url/#URL.Parse
 url.Parse] is what you would use to resolve a relative path against a base
 URL.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9974#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs