[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4677 [Tor]: master won't build without V2_HANDSHAKE_SERVER

#4677: master won't build without V2_HANDSHAKE_SERVER
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  closed
     Priority:  minor   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:  fixed   |   Keywords:  easy tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks okay, except that the change to the condition on
 tor_tls_session_secret_cb was wrong.  It needs to happen unconditionally,
 so that the ciphersuite detection logic that lets us use ciphers from the
 unrestricted list can work.  (See proposal 198 for information on why
 that's necessary.)  Merging this as-is would have turned off all the ECDHE
 ciphers.

 Fixed in 8f9c847fbf4032a8db4802708f7e2d69a26cd3d2 and merged.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4677#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs