[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9941 [Pluggable transport]: Add FTE to Pluggable Transport Tor Browser Bundle

#9941: Add FTE to Pluggable Transport Tor Browser Bundle
-------------------------------------+--------------------
     Reporter:  kpdyer               |      Owner:  kpdyer
         Type:  enhancement          |     Status:  closed
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:  implemented          |   Keywords:
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+--------------------

Comment (by dcf):

 Thanks for this work. I pushed your branch to the torproject.org repo.

 https://gitweb.torproject.org/pluggable-
 transports/bundle.git/shortlog/refs/heads/fte

 Here are some notes.

 `FTEPROXY_TAG` is meant to be a git tag. If you're not using git, you
 might want to call it `FTEPROXY_VERSION` or something, and have a separate
 step for the download. The various targets in Makefile definitely should
 not be downloading files with curl (and shouldn't be downloading the file
 fresh every time).

 The patch changes `MACOSX_BUNDLE_ROOT`. This actually changed in master
 probably since you made your branch. You might have to rearrange your OS X
 working directory. See https://gitweb.torproject.org/pluggable-
 transports/bundle.git/commitdiff/7d9fc634cbcb281af775b6e17971777edf6ad1c1,
 https://gitweb.torproject.org/pluggable-
 transports/bundle.git/commitdiff/86efa19e1d7fb8f75cd1d9b126d40263658d27bb,
 and https://gitweb.torproject.org/pluggable-
 transports/bundle.git/commitdiff/9260e7b591ec7a5ffa7f032c1dd9ff287568f987.

 Makefile seems to be downloading precompiled binaries of the fteproxy
 program. Really, it should build its own binaries from source code, like
 the other transports do. (It's a bit different for flash proxy and
 obfsproxy because they are written in Python, but for example on Windows
 we call their py2exe targets.)

 Finally, I hate that you got caught in a transition between build systems,
 but the bundle branch is nearly defunct and probably won't be used to make
 future bundles. The pt branch in #9444 is now working well enough to build
 bundles on all platforms, so you might like to see what is needed to
 incorporate FTE there. (Grep the history for "Fetch obfsproxy" and
 "Install obfsproxy" for examples.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9941#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs