[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8510 [Tor]: Add useful Hidden Service related events to the Tor control port

#8510: Add useful Hidden Service related events to the Tor control port
-------------------------+----------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:  task     |     Status:  needs_revision
     Priority:  normal   |  Milestone:  Tor: unspecified
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-hs controller needs-proposal
Actual Points:           |  Parent ID:  #8993
       Points:           |
-------------------------+----------------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Okay, another round of reviews. (Sorry about the delays):

   * We should prefer tor_malloc to malloc(); we should prefer
 tor_malloc_zero() to malloc()+bzero(). We should use tor_free(), not
 free().
   * This won't build with all our gcc warnings enabled. (It uses C99
 constructs by declaring variables in the middle of blocks.)
   * node_describe(rs) is a better choice than
 routerstatus_describe(node->rs) for describing nodes.
   * The tor_assert(hs_dir_node) thing makes me worry about race conditions
 where the node goes away after the circuit is launched.  Perhaps we can
 send events with node_describe(hs_dir_node) when hs_dir_node is non-null,
 and with the base 16 encoding if the ID when node_get_by_id() returns
 NULL?  That would be a fine thing to wrap into a "node_describe_by_id()"
 function.
   * Most of these new functions lack documentation.  See doc/HACKING for a
 documentation style.

 Anybody on the cc list want to offer to help dave2008 out with these
 changes? We've left him hanging for a while, they're fairly simple
 changes, and it would be cool to pick up some of our slack.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8510#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs