[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17576 [Tor]: Add torrc option to disable default fallback directories
#17576: Add torrc option to disable default fallback directories
-------------------------------+------------------------------------
Reporter: teor | Owner:
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.2.8.x-final
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: TorCoreTeam201511 | Actual Points:
Parent ID: #15775 | Points:
Sponsor: |
-------------------------------+------------------------------------
Comment (by teor):
Replying to [comment:4 nickm]:
> Looks great except one thing: the code in options_validate() that
changes UseDefaultFallbackDirs is a bad idea, since that will cause later
SAVECONF calls to write the new UseDefaultFallbackDirs value to disk even
if the user didn't mean for it to change.
>
> ...
> * Always ignore UseDefaultFallbackDirs when FallbackDirs is set.
This is what the code already does by checking `!options->FallbackDir &&
options->UseDefaultFallbackDirs`. I changed options_validate so that it
didn't change the value of UseDefaultFallbackDirs, and updated the info
message.
Please see my branch feature17576-UseDefaultFallbackDirs-v2.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17576#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs