Re: [tor-bugs] #20714 [Metrics/CollecTor]: Retain hidserv- lines in sanitized bridge extra-info descriptors

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20714: Retain hidserv- lines in sanitized bridge extra-info descriptors
-------------------------------+---------------------------------
 Reporter:  karsten            |          Owner:  metrics-team
     Type:  defect             |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.1.1
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by iwakeh):

 Looks good, just a few minor things:

 LICENSE:
 {{{
 - Copyright 2010--2012 The Tor Project
 + Copyright 2010--2016 The Tor Project
 }}}
 Currently there is only the license for apache commons items added.
 Maybe, add the other contents of Onionoo's license file here too?

 CHANGELOG.md
 {{{
  * Minor changes
    - Add instructions and sample configuration for using nginx as HTTP
 -     server rather than Apache.
 +     server as an alternative to Apache.
 }}}
 Apache is still an option and surely the more popular one, but nginx can
 be used, too.

 Would it be very cumbersome to make the hidserv-lines be part of a test?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20714#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs