[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20412 [Metrics/Onionoo]: Skip bad archived descriptors rather than aborting the entire import

#20412: Skip bad archived descriptors rather than aborting the entire import
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2017     |  Actual Points:
Parent ID:  #20548           |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+------------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 The fix looks ok and ready for merge.
 (Was the initial implementation just chance or was there a reason for
 halting the import?)

 I'm wondering, if the actual issue isn't in metrics-lib.
 Shouldn't there be a method `finishReading` that halts the reading process
 on client request?  Clients shouldn't be forced to read all available
 descriptors.  Afaik, the ISE is just due to calling the statistics methods
 before all was read.  New ticket for metrics-lib?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20412#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs