[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1
#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced
1 node(s); held_by_nodes == 1
-------------------------------------------------+-------------------------
Reporter: jaj123 | Owner: nickm
Type: defect | Status:
| needs_review
Priority: High | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.4.19
Severity: Normal | Resolution:
Keywords: tor-client, 025-backport, nickm- | Actual Points:
should-review, review-group-24 |
Parent ID: | Points: 2
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by asn):
Hm, took a look at this ticket given that I have spent some time with mds
lately. I don't entirely understand the `dc60e87d6` fix here. I think some
more docs would be appreciated.
Why do we call `update_microdescs_from_networkstatus()` in
`networkstatus_note_certs_arrived()` and not in
`networkstatus_set_current_consensus()`? Would we ever want to update our
microdescs if we didn't actually successfuly set a consensus, and we just
fetched some certs?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7164#comment:97>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs