[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23817 [Core Tor/Tor]: Tor re-tries directory mirrors that it knows are missing microdescriptors
#23817: Tor re-tries directory mirrors that it knows are missing microdescriptors
-------------------------------------------------+-------------------------
Reporter: teor | Owner: (none)
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-guard, tor-hs, prop224, | Actual Points:
032-backport? 031-backport? spec-change |
Parent ID: #21969 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Also, rst in the unit tests needs to be declared before any gotos, and set
to NULL at declaration time:
{{{
src/test/test_entrynodes.c:1810:3: error: variable 'rst' is used
uninitialized
whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
tt_ptr_op(g2, OP_EQ, g);
^~~~~~~~~~~~~~~~~~~~~~~
./src/ext/tinytest_macros.h:166:2: note: expanded from macro 'tt_ptr_op'
tt_assert_test_type(a,b,#a" "#op" "#b,const void*, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/ext/tinytest_macros.h:144:2: note: expanded from macro
'tt_assert_test_type'
tt_assert_test_fmt_type(a,b,str_test,type,test,type,fmt, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/ext/tinytest_macros.h:136:7: note: expanded from macro
'tt_assert_test_fmt_type'
if (!tt_status_) { \
^~~~~~~~~~~
src/test/test_entrynodes.c:1820:32: note: uninitialized use occurs here
entry_guard_restriction_free(rst);
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23817#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs