[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23523 [Core Tor/Tor]: Handle extreme values better in add_laplace_noise()

#23523: Handle extreme values better in add_laplace_noise()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, privcount, review-        |  Actual Points:
  group-24                                       |
Parent ID:  #23061                               |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  SponsorQ
-------------------------------------------------+-------------------------

Comment (by catalyst):

 I'm still looking over this. One thing that sticks out is that the comment
 in `get_min_safe_noise()` is inaccurate and caused me to misinterpret what
 it's actually doing on platforms with `DBL_MANT_DIG` less than 64.  It
 might be more correct to say "This is always safe, because floating point
 numbers are sign-magnitude and the negation of an exact number is also
 exact."

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23523#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs