Re: [tor-bugs] #23577 [Core Tor/Tor]: Add rendezvous point IPv6 address to client introduce cells

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23577: Add rendezvous point IPv6 address to client introduce cells
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:  2
  ipv6, review-group-25                          |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------

Comment (by neel):

 Would setting {{{intro1_data}}} to {{{0}}} in
 {{{hs_circ_send_introduce1()}}} be enough? I see that {{{intro1_data}}} is
 not a pointer variable, and it seems the expression {{{{0} }}} is for a
 pointer or array.

 Replying to [comment:28 dgoulet]:
 > Replying to [comment:26 neel]:
 > > I have a patch which (hopefully) should resolve the two issues. The
 filename is 008-bugfix1.patch​.
 >
 > Thanks neel for the patch.
 >
 > Continuing on teor's review, I also would go with a pattern like this
 instead:
 >
 > {{{
 > if (exit_node == NULL) {
 >   log_info(...)
 >   goto done;
 > }
 > setup_intro1()
 > }}}
 >
 > The reason I think we should go with a `log_info()` instead of warning
 is because this is a very very rare race condition so if it occurs, no
 need for a warning because it is a possible "normal behavior" .
 >
 > The SOCKS connection will fail but at that point the application can
 retry and chances are that it will succeed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23577#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs