[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23577 [Core Tor/Tor]: Add rendezvous point IPv6 address to client introduce cells

#23577: Add rendezvous point IPv6 address to client introduce cells
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:  2
  ipv6, review-group-25                          |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 Replying to [comment:29 neel]:
 > Would setting {{{intro1_data}}} to {{{0}}} in
 {{{hs_circ_send_introduce1()}}} be enough? I see that {{{intro1_data}}} is
 not a pointer variable, and it seems the expression {{{{0} }}} is for a
 pointer or array.

 I'm wondering why it didn't work for you:

 `hs_cell_introduce1_data_t intro1_data = {0};`

 That would be better than using malloc().

 The rest lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23577#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs