[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23100 [Core Tor/Tor]: Circuit Build Timeout needs to count hidden service circuits
#23100: Circuit Build Timeout needs to count hidden service circuits
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner:
| mikeperry
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.7
Severity: Normal | Resolution:
Keywords: tor-hs, path-bias, guard-discovery- | Actual Points:
prop247-controller, needs-proposal, mike-can, |
prop247, tor-guard, review-group-25 |
Parent ID: #9001 | Points:
Reviewer: asn | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mikeperry):
Ok, I separated bug #23100 without the tests. mikeperry/bug23100-squashed
is just that (and is the same commit hash for #23100 from bugs23100+23114
-cleanup-squashed2). mikeperry/bug23100-presquashed-fixups contains just
the fixups in that commit.
I think I also see where you got confused with the rebase. I accidentally
labeled the refactoring commits as fixups to #23100, since you asked for
them in that review. I simply removed those commits from
mikeperry/bug23100-presquashed-fixups now. They will be part of #23114.
I will annotate the gitlab review with the fixup commit hashes for your
comments.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23100#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs