[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character
#24361: rbm gives an error if a build script contains a wide character
--------------------------------------------+------------------------------
Reporter: boklm | Owner: boklm
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/rbm | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201712R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------------
Changes (by boklm):
* status: new => needs_review
* keywords: tbb-rbm, TorBrowserTeam201712 => tbb-rbm,
TorBrowserTeam201712R
Comment:
The branch `bug_24361` in my git repo has a patch to fix this:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_24361&id=134cad4e79471d7baa82f00b4a6e2d7f7d11868a
This change should not modify the sha256sum of build scripts which do not
contain any wide character. I checked that the `var/build_id` value (which
is doing a `sha256` on the build script and all dependencies) reported by
the following commands is identical with and without the patch:
{{{
./rbm/rbm showconf --target alpha --target torbrowser-linux-x86_64 tor-
browser var/build_id
./rbm/rbm showconf --target alpha --target torbrowser-windows-x86_64 tor-
browser var/build_id
./rbm/rbm showconf --target alpha --target torbrowser-osx-x86_64 tor-
browser var/build_id
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24361#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs